infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-28 16:50:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

8374915: Move assertion in GenericTaskQueue<>::pop_global()

Browse Source 
Reviewed-by: tschatzl, ayang
This commit is contained in:
Kim Barrett 2026-03-25 15:19:32 +00:00
parent 2a6d92fd27
commit ca0bee78f5
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hotspot/share/gc/shared/taskqueue.inline.hpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -279,13 +279,11 @@ typename GenericTaskQueue<E, MT, N>::PopResult GenericTaskQueue<E, MT, N>::pop_g
// Increment top; if it wraps, also increment tag, to distinguish it
// from any recent _age for the same top() index.
idx_t new_top = increment_index(oldAge.top());
// Don't use bottom, since a pop_local might have decremented it.
assert_not_underflow(localBot, new_top);
idx_t new_tag = oldAge.tag() + ((new_top == 0) ? 1 : 0);
Age newAge(new_top, new_tag);
bool result = par_set_age(oldAge, newAge);
// Note that using "bottom" here might fail, since a pop_local might
// have decremented it.
assert_not_underflow(localBot, newAge.top());
return result ? PopResult::Success : PopResult::Contended;
}