From cbab40bce45a2f58906be49c841178fa1dfd457e Mon Sep 17 00:00:00 2001 From: Magnus Ihse Bursie Date: Wed, 11 Dec 2024 21:01:20 +0000 Subject: [PATCH] 8345683: Remove special flags for files compiled for static libraries Reviewed-by: erikj --- make/autoconf/flags-cflags.m4 | 17 ----------------- make/autoconf/spec.gmk.template | 2 -- make/common/native/Flags.gmk | 2 +- 3 files changed, 1 insertion(+), 20 deletions(-) diff --git a/make/autoconf/flags-cflags.m4 b/make/autoconf/flags-cflags.m4 index f78ccfe3762..259315bb23c 100644 --- a/make/autoconf/flags-cflags.m4 +++ b/make/autoconf/flags-cflags.m4 @@ -640,23 +640,6 @@ AC_DEFUN([FLAGS_SETUP_CFLAGS_HELPER], # Linking is different on macOS JVM_PICFLAG="" fi - - # Extra flags needed when building optional static versions of certain - # JDK libraries. - STATIC_LIBS_CFLAGS="-DSTATIC_BUILD=1" - if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" = xclang; then - STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS -ffunction-sections -fdata-sections \ - -DJNIEXPORT='__attribute__((visibility(\"default\")))'" - else - STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS -DJNIEXPORT=" - fi - if test "x$TOOLCHAIN_TYPE" = xgcc; then - # Disable relax-relocation to enable compatibility with older linkers - RELAX_RELOCATIONS_FLAG="-Xassembler -mrelax-relocations=no" - FLAGS_COMPILER_CHECK_ARGUMENTS(ARGUMENT: [${RELAX_RELOCATIONS_FLAG}], - IF_TRUE: [STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS ${RELAX_RELOCATIONS_FLAG}"]) - fi - AC_SUBST(STATIC_LIBS_CFLAGS) ]) ################################################################################ diff --git a/make/autoconf/spec.gmk.template b/make/autoconf/spec.gmk.template index 18770c6d360..2637285334b 100644 --- a/make/autoconf/spec.gmk.template +++ b/make/autoconf/spec.gmk.template @@ -429,8 +429,6 @@ LIBFFI_LIB_FILE := @LIBFFI_LIB_FILE@ FILE_MACRO_CFLAGS := @FILE_MACRO_CFLAGS@ REPRODUCIBLE_CFLAGS := @REPRODUCIBLE_CFLAGS@ -STATIC_LIBS_CFLAGS := @STATIC_LIBS_CFLAGS@ - JMH_CORE_JAR := @JMH_CORE_JAR@ JMH_GENERATOR_JAR := @JMH_GENERATOR_JAR@ JMH_JOPT_SIMPLE_JAR := @JMH_JOPT_SIMPLE_JAR@ diff --git a/make/common/native/Flags.gmk b/make/common/native/Flags.gmk index 213312047a4..daa9a83d62b 100644 --- a/make/common/native/Flags.gmk +++ b/make/common/native/Flags.gmk @@ -99,7 +99,7 @@ define SetupCompilerFlags $1_EXTRA_CFLAGS += $$($1_CFLAGS_$(OPENJDK_TARGET_OS)_$(OPENJDK_TARGET_CPU)_release) endif ifeq ($(STATIC_LIBS), true) - $1_EXTRA_CFLAGS += $$(STATIC_LIBS_CFLAGS) + $1_EXTRA_CFLAGS += -DSTATIC_BUILD=1 endif # Pickup extra OPENJDK_TARGET_OS_TYPE, OPENJDK_TARGET_OS and/or TOOLCHAIN_TYPE