infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-08-03 06:35:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix localhost check in ListeningConnector.startListening test

Browse Source 
Prior to this patch, the test failed if the hostname returned by
`startListening()` didn't match either the string "localhost" or the IP
addresses associated with "localhost", but this is fragile.  On machines
where a reverse lookup on 127.0.0.1 returns a string other than
localhost, the test fails, like in the following example:

```
>_ jdb -connect com.sun.jdi.SocketListen:port=50000
Listening at address: kubernetes.docker.internal:50000
...

>_ make test TEST=.../startlis001/TestDescription.java
...
Test case #1: start listening the address kubernetes.docker.internal:49532
Expected addresses: localhost:null or 127.0.0.1:null or 0:0:0:0:0:0:0:1:null
...
```

As a workaround, this patch uses `InetAddress.isLoopbackAddress()` on
the hostname portion of the address that is being listened.

Validated this patch on machines where the reverse lookup resolves to
either "localhost" or a different string.
This commit is contained in:
Ashay Rane 2026-07-01 14:39:58 -05:00
parent ce87f11a1d
commit ce6af25243
No known key found for this signature in database
GPG Key ID: 52864602A7AB7825
1 changed files with 23 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
test/hotspot/jtreg/vmTestbase/nsk/jdi/ListeningConnector/startListening/startlis001.java
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -32,12 +32,9 @@ import java.io.*;
import java.net.InetAddress;
import java.net.UnknownHostException;
import java.util.Arrays;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
import nsk.share.*;
import nsk.share.jpda.*;
@ -88,6 +85,26 @@ public class startlis001 {
return new startlis001().runIt(argv, out);
}
private boolean isExpectedLoopbackAddress(String listenAddr, String expectedPort) {
int split = listenAddr.lastIndexOf(':');
if (split < 0) {
return false;
}
String host = listenAddr.substring(0, split);
String actualPort = listenAddr.substring(split + 1);
if (expectedPort != null && !actualPort.equals(expectedPort)) {
return false;
}
try {
return InetAddress.getByName(host).isLoopbackAddress();
} catch (UnknownHostException e) {
return false;
}
}
private int runIt(String argv[], PrintStream out) {
String port;
String addr;
@ -101,23 +118,6 @@ public class startlis001 {
log = new Log(out, argHandler);
long timeout = argHandler.getWaitTime() * 60 * 1000;
/* Check that listening address returned by ListeningConnector.startListening()
* matches the address which was set via connector's arguments.
* Empty host address causes listening for local connections only (loopback interface).
* */
String hostname = "localhost";
List<String> validAddresses = new LinkedList<>();
validAddresses.add(hostname);
try {
Arrays.stream(InetAddress.getAllByName(hostname))
.forEach(address -> validAddresses.add(address.getHostAddress()));
} catch (UnknownHostException e) {
log.complain("FAILURE: caught UnknownHostException " +
e.getMessage());
totalRes = false;
}
port = argHandler.getTransportPortIfNotDynamic();
initConnector(port);
@ -125,17 +125,11 @@ public class startlis001 {
log.complain("Test case #1 FAILED: unable to start listening");
totalRes = false;
} else {
String validAddrList = validAddresses.stream()
.map(value -> value + ":" + port)
.collect(Collectors.joining(" or "));
log.display("Test case #1: start listening the address " + addr);
log.display("Expected addresses: " + validAddrList);
final String listenAddr = addr;
boolean isValid = validAddresses.stream()
.anyMatch(value -> listenAddr.startsWith(value) && (port == null || listenAddr.endsWith(port)));
if (!isValid) {
if (!isExpectedLoopbackAddress(listenAddr, port)) {
log.complain("Test case #1 FAILED: listening address " + addr +
"\ndoes not match expected address:\n" + validAddrList);
"\ndoes not match expected a loopback address");
totalRes = false;
}
if (!stopListen()) {