infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-07-28 03:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

8332236: javac crashes with module imports and implicitly declared class

Browse Source 
Reviewed-by: vromero
This commit is contained in:
Jan Lahoda 2024-05-15 05:43:18 +00:00
parent 4e77cf881d
commit d04ac14bdb
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
View File

@ -4118,7 +4118,7 @@ public class JavacParser implements Parser {
for (JCTree def : origDefs) {
if (def.hasTag(Tag.PACKAGEDEF)) {
log.error(def.pos(), Errors.ImplicitClassShouldNotHavePackageDeclaration);
} else if (def.hasTag(Tag.IMPORT)) {
} else if (def.hasTag(Tag.IMPORT) || def.hasTag(Tag.MODULEIMPORT)) {
topDefs.append(def);
} else if (!def.hasTag(Tag.SKIP)) {
defs.append(def);

24
test/langtools/tools/javac/ImportModule.java
View File

@ -23,7 +23,7 @@
/**
* @test
* @bug 8328481
* @bug 8328481 8332236
* @summary Check behavior of module imports.
* @library /tools/lib
* @modules java.logging
@ -719,4 +719,26 @@ public class ImportModule extends TestRunner {
.writeAll();
}
@Test
public void testImplicitlyDeclaredClass(Path base) throws Exception {
Path current = base.resolve(".");
Path src = current.resolve("src");
Path classes = current.resolve("classes");
tb.writeFile(src.resolve("Test.java"),
"""
import module java.base;
void main() {
}
""");
Files.createDirectories(classes);
new JavacTask(tb)
.options("--enable-preview", "--release", SOURCE_VERSION)
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Task.Expect.SUCCESS)
.writeAll();
}
}