From d2956c2e8d83e1627bfa4a80016b6314d1bd3a3b Mon Sep 17 00:00:00 2001 From: Dan Xu Date: Thu, 15 Aug 2013 14:11:16 -0700 Subject: [PATCH] 8017109: Cleanup overrides warning in src/solaris/classes/sun/print/AttributeClass.java Reviewed-by: jgodinez --- .../classes/sun/print/AttributeClass.java | 22 +++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/jdk/src/solaris/classes/sun/print/AttributeClass.java b/jdk/src/solaris/classes/sun/print/AttributeClass.java index a897de16458..f9018dce19f 100644 --- a/jdk/src/solaris/classes/sun/print/AttributeClass.java +++ b/jdk/src/solaris/classes/sun/print/AttributeClass.java @@ -24,6 +24,7 @@ */ package sun.print; +import java.util.Objects; import java.io.ByteArrayInputStream; public class AttributeClass { @@ -248,11 +249,24 @@ public class AttributeClass { return myName; } + @Override public boolean equals(Object obj) { - return - obj != null && - obj instanceof AttributeClass && - obj.toString().equals (((AttributeClass) obj).toString()); + if (!(obj instanceof AttributeClass)) { + return false; + } + if (this == obj) { + return true; + } + + AttributeClass acObj = (AttributeClass) obj; + return myType == acObj.getType() && + Objects.equals(myName, acObj.getName()) && + Objects.equals(myValue, acObj.getObjectValue()); + } + + @Override + public int hashCode() { + return Objects.hash(myType, myName, myValue); } public String toString() {