From d5391d290d0e66b430106cf31df2a9421eabe63f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Per=20Lid=C3=A9n?= Date: Tue, 7 May 2019 07:44:15 +0200 Subject: [PATCH] 8223308: ZGC: Remove ZGranuleMap::size() Reviewed-by: stefank, eosterlund --- src/hotspot/share/gc/z/zGranuleMap.hpp | 4 ++-- src/hotspot/share/gc/z/zGranuleMap.inline.hpp | 16 ++++++---------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/hotspot/share/gc/z/zGranuleMap.hpp b/src/hotspot/share/gc/z/zGranuleMap.hpp index ec359848064..6f6b5385a66 100644 --- a/src/hotspot/share/gc/z/zGranuleMap.hpp +++ b/src/hotspot/share/gc/z/zGranuleMap.hpp @@ -35,10 +35,10 @@ class ZGranuleMap { friend class ZGranuleMapIterator; private: - T* const _map; + const size_t _size; + T* const _map; size_t index_for_addr(uintptr_t addr) const; - size_t size() const; public: ZGranuleMap(); diff --git a/src/hotspot/share/gc/z/zGranuleMap.inline.hpp b/src/hotspot/share/gc/z/zGranuleMap.inline.hpp index 740a0ffbd06..e38c04cf7bb 100644 --- a/src/hotspot/share/gc/z/zGranuleMap.inline.hpp +++ b/src/hotspot/share/gc/z/zGranuleMap.inline.hpp @@ -31,11 +31,12 @@ template inline ZGranuleMap::ZGranuleMap() : - _map(MmapArrayAllocator::allocate(size(), mtGC)) {} + _size(ZAddressOffsetMax >> ZGranuleSizeShift), + _map(MmapArrayAllocator::allocate(_size, mtGC)) {} template inline ZGranuleMap::~ZGranuleMap() { - MmapArrayAllocator::free(_map, size()); + MmapArrayAllocator::free(_map, _size); } template @@ -43,16 +44,11 @@ inline size_t ZGranuleMap::index_for_addr(uintptr_t addr) const { assert(!ZAddress::is_null(addr), "Invalid address"); const size_t index = ZAddress::offset(addr) >> ZGranuleSizeShift; - assert(index < size(), "Invalid index"); + assert(index < _size, "Invalid index"); return index; } -template -inline size_t ZGranuleMap::size() const { - return ZAddressOffsetMax >> ZGranuleSizeShift; -} - template inline T ZGranuleMap::get(uintptr_t addr) const { const size_t index = index_for_addr(addr); @@ -83,7 +79,7 @@ inline ZGranuleMapIterator::ZGranuleMapIterator(const ZGranuleMap* map) : template inline bool ZGranuleMapIterator::next(T* value) { - if (_next < _map->size()) { + if (_next < _map->_size) { *value = _map->_map[_next++]; return true; } @@ -94,7 +90,7 @@ inline bool ZGranuleMapIterator::next(T* value) { template inline bool ZGranuleMapIterator::next(T** value) { - if (_next < _map->size()) { + if (_next < _map->_size) { *value = _map->_map + _next++; return true; }