8298521: Rename members in G1MonitoringSupport

Reviewed-by: ayang, tschatzl
This commit is contained in:
Yude Lin 2022-12-13 10:26:05 +00:00 committed by Thomas Schatzl
parent 3b1142a280
commit dbcfe7bc33
2 changed files with 14 additions and 14 deletions

View File

@ -88,13 +88,13 @@ public:
G1MonitoringSupport::G1MonitoringSupport(G1CollectedHeap* g1h) :
_g1h(g1h),
_incremental_memory_manager("G1 Young Generation", "end of minor GC"),
_young_gc_memory_manager("G1 Young Generation", "end of minor GC"),
_full_gc_memory_manager("G1 Old Generation", "end of major GC"),
_conc_gc_memory_manager("G1 Concurrent GC", "end of concurrent GC pause"),
_eden_space_pool(NULL),
_survivor_space_pool(NULL),
_old_gen_pool(NULL),
_incremental_collection_counters(NULL),
_young_collection_counters(NULL),
_full_collection_counters(NULL),
_conc_collection_counters(NULL),
_young_gen_counters(NULL),
@ -121,7 +121,7 @@ G1MonitoringSupport::G1MonitoringSupport(G1CollectedHeap* g1h) :
//
// name "collector.0". In a generational collector this would be the
// young generation collection.
_incremental_collection_counters =
_young_collection_counters =
new CollectorCounters("G1 young collection pauses", 0);
// name "collector.1". In a generational collector this would be the
// old generation collection.
@ -202,9 +202,9 @@ void G1MonitoringSupport::initialize_serviceability() {
_conc_gc_memory_manager.add_pool(_old_gen_pool);
_incremental_memory_manager.add_pool(_eden_space_pool);
_incremental_memory_manager.add_pool(_survivor_space_pool);
_incremental_memory_manager.add_pool(_old_gen_pool, false /* always_affected_by_gc */);
_young_gc_memory_manager.add_pool(_eden_space_pool);
_young_gc_memory_manager.add_pool(_survivor_space_pool);
_young_gc_memory_manager.add_pool(_old_gen_pool, false /* always_affected_by_gc */);
}
MemoryUsage G1MonitoringSupport::memory_usage() {
@ -214,7 +214,7 @@ MemoryUsage G1MonitoringSupport::memory_usage() {
GrowableArray<GCMemoryManager*> G1MonitoringSupport::memory_managers() {
GrowableArray<GCMemoryManager*> memory_managers(3);
memory_managers.append(&_incremental_memory_manager);
memory_managers.append(&_young_gc_memory_manager);
memory_managers.append(&_full_gc_memory_manager);
memory_managers.append(&_conc_gc_memory_manager);
return memory_managers;
@ -298,7 +298,7 @@ void G1MonitoringSupport::update_sizes() {
if (UsePerfData) {
_eden_space_counters->update_capacity(pad_capacity(_eden_space_committed));
_eden_space_counters->update_used(_eden_space_used);
// only the "to" survivor space is active, so we don't need to
// only the "to" survivor space is active, so we don't need to
// update the counters for the "from" survivor space
_to_space_counters->update_capacity(pad_capacity(_survivor_space_committed));
_to_space_counters->update_used(_survivor_space_used);
@ -367,8 +367,8 @@ G1MonitoringScope::~G1MonitoringScope() {
G1YoungGCMonitoringScope::G1YoungGCMonitoringScope(G1MonitoringSupport* monitoring_support,
bool all_memory_pools_affected) :
G1MonitoringScope(monitoring_support,
monitoring_support->_incremental_collection_counters,
&monitoring_support->_incremental_memory_manager,
monitoring_support->_young_collection_counters,
&monitoring_support->_young_gc_memory_manager,
all_memory_pools_affected) {
}

View File

@ -128,7 +128,7 @@ class G1MonitoringSupport : public CHeapObj<mtGC> {
G1CollectedHeap* _g1h;
// java.lang.management MemoryManager and MemoryPool support
GCMemoryManager _incremental_memory_manager;
GCMemoryManager _young_gc_memory_manager;
GCMemoryManager _full_gc_memory_manager;
GCMemoryManager _conc_gc_memory_manager;
@ -137,11 +137,11 @@ class G1MonitoringSupport : public CHeapObj<mtGC> {
MemoryPool* _old_gen_pool;
// jstat performance counters
// incremental collections both young and mixed
CollectorCounters* _incremental_collection_counters;
// young stop-the-world collections (including mixed)
CollectorCounters* _young_collection_counters;
// full stop-the-world collections
CollectorCounters* _full_collection_counters;
// stop-the-world phases in G1
// stop-the-world phases in G1 concurrent collection
CollectorCounters* _conc_collection_counters;
// young collection set counters. The _eden_counters,
// _from_counters, and _to_counters are associated with