infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-14 09:53:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

8371420: Still sporadic failures of gc/TestAlwaysPreTouchBehavior.java#<gcname> on Linux after JDK-8359104

Browse Source 
Reviewed-by: mdoerr, ayang
This commit is contained in:
Matthias Baesken 2025-12-19 14:28:04 +00:00
parent b5ac8f8368
commit dca55b4366
1 changed files with 23 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
test/hotspot/jtreg/gc/TestAlwaysPreTouchBehavior.java
View File

@ -133,13 +133,8 @@ public class TestAlwaysPreTouchBehavior {
//
public static void main(String [] args) {
long rss = WhiteBox.getWhiteBox().rss();
System.out.println("RSS: " + rss);
long available = WhiteBox.getWhiteBox().hostAvailableMemory();
System.out.println("Host available memory: " + available);
int maxIter = 20;
long heapSize = 256 * 1024 * 1024;
// On Linux, a JVM that runs with 256M pre-committed heap will use about 60MB (release JVM) RSS. Barring
// memory pressure that causes us to lose RSS, pretouching should increase RSS to >256MB. So there should be a
// clear distinction between non-pretouched and pretouched.
@ -150,12 +145,28 @@ public class TestAlwaysPreTouchBehavior {
// on the side of disregarding true errors than to produce false positives (if pretouching is broken, at least
// some of the runs of this test will run on beefy enough machines and show the test as failed).
long requiredAvailable = 1024 * 1024 * 1024;
if (rss == 0) {
throw new SkippedException("cannot get RSS?");
}
if (available > requiredAvailable) {
Asserts.assertGreaterThan(rss, minRequiredRss, "RSS of this process(" + rss + "b) should be bigger " +
"than or equal to heap size(" + heapSize + "b) (available memory: " + available + "). On Linux Kernel < 4.14 RSS can be inaccurate");
// RSS values we get are sometimes somewhat delayed or inaccurate
for (int iter=0; iter < maxIter; iter++) {
long rss = WhiteBox.getWhiteBox().rss();
System.out.println("RSS: " + rss);
long available = WhiteBox.getWhiteBox().hostAvailableMemory();
System.out.println("Host available memory: " + available);
if (rss == 0) {
throw new SkippedException("cannot get RSS?");
}
if (available <= requiredAvailable) {
throw new SkippedException("Available memory on host " + available + " is too small, not larger than required available memory " + requiredAvailable);
}
if ((rss < minRequiredRss) && iter < maxIter-1) {
System.out.println("We got only an RSS value of " + rss + " but require " + minRequiredRss + ", let's retry!");
} else {
Asserts.assertGreaterThan(rss, minRequiredRss, "RSS of this process(" + rss + "b) should be bigger " +
"than or equal to heap size(" + heapSize + "b) (available memory: " + available + "). On Linux Kernel < 4.14 RSS can be inaccurate");
break;
}
}
}
}