infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

8242802: javac crashes when checking equals and hashCode in unresolvable anonymous class

Browse Source 
Preventing NullPointerException when a class has an erroneous supertype and does not have an implementation of the equals method.

Reviewed-by: darcy, vromero
This commit is contained in:
Jan Lahoda 2020-04-20 12:36:09 +02:00
parent f08b5a8006
commit df82d9a4b5
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java
View File

@ -2145,8 +2145,10 @@ public class Check {
.tsym.members().findFirst(names.equals);
MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
.tsym.members().findFirst(names.hashCode);
boolean overridesEquals = types.implementation(equalsAtObject,
someClass, false, equalsHasCodeFilter).owner == someClass;
MethodSymbol equalsImpl = types.implementation(equalsAtObject,
someClass, false, equalsHasCodeFilter);
boolean overridesEquals = equalsImpl != null &&
equalsImpl.owner == someClass;
boolean overridesHashCode = types.implementation(hashCodeAtObject,
someClass, false, equalsHasCodeFilter) != hashCodeAtObject;

12
test/langtools/tools/javac/6563143/InvalidAnonymous.java Normal file
View File

@ -0,0 +1,12 @@
/*
* @test /nodynamiccopyright/
* @bug 8242802
* @summary Verify javac does not crash while checking for equals/hashCode overrides
* @compile/fail/ref=InvalidAnonymous.out -XDrawDiagnostics InvalidAnonymous.java
* @compile/fail/ref=InvalidAnonymous.out -XDrawDiagnostics -Xlint:overrides InvalidAnonymous.java
*/
public class InvalidAnonymous {
private void t() {
new Undefined() {};
}
}

2
test/langtools/tools/javac/6563143/InvalidAnonymous.out Normal file
View File

@ -0,0 +1,2 @@
InvalidAnonymous.java:10:13: compiler.err.cant.resolve.location: kindname.class, Undefined, , , (compiler.misc.location: kindname.class, InvalidAnonymous, null)
1 error