From e2b50eff2b2f7e4ea1ee17ffbfd830f72a7d0fbc Mon Sep 17 00:00:00 2001 From: Sergey Bylokhov Date: Tue, 14 Mar 2017 18:35:32 +0300 Subject: [PATCH] 8176177: The new SwingContainer annotation can be removed from javax.accessibility.AccessibleContext Reviewed-by: alexsch, malenkov --- .../accessibility/AccessibleContext.java | 5 +- .../SwingContainerIsForContainerOnly.java | 72 +++++++++++++++++++ 2 files changed, 73 insertions(+), 4 deletions(-) create mode 100644 jdk/test/javax/swing/SwingContainer/SwingContainerIsForContainerOnly/SwingContainerIsForContainerOnly.java diff --git a/jdk/src/java.desktop/share/classes/javax/accessibility/AccessibleContext.java b/jdk/src/java.desktop/share/classes/javax/accessibility/AccessibleContext.java index c3a30f3a5ae..44404ef9aa2 100644 --- a/jdk/src/java.desktop/share/classes/javax/accessibility/AccessibleContext.java +++ b/jdk/src/java.desktop/share/classes/javax/accessibility/AccessibleContext.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -36,8 +36,6 @@ import java.beans.PropertyChangeSupport; import java.beans.PropertyChangeEvent; import java.awt.IllegalComponentStateException; -import javax.swing.SwingContainer; - /** * AccessibleContext represents the minimum information all accessible objects * return. This information includes the accessible name, description, role, @@ -79,7 +77,6 @@ import javax.swing.SwingContainer; * @author Lynn Monsanto */ @JavaBean(description = "Minimal information that all accessible objects return") -@SwingContainer(false) public abstract class AccessibleContext { /** diff --git a/jdk/test/javax/swing/SwingContainer/SwingContainerIsForContainerOnly/SwingContainerIsForContainerOnly.java b/jdk/test/javax/swing/SwingContainer/SwingContainerIsForContainerOnly/SwingContainerIsForContainerOnly.java new file mode 100644 index 00000000000..42bbf3c4942 --- /dev/null +++ b/jdk/test/javax/swing/SwingContainer/SwingContainerIsForContainerOnly/SwingContainerIsForContainerOnly.java @@ -0,0 +1,72 @@ +/* + * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +import java.awt.Container; +import java.io.IOException; +import java.net.URI; +import java.nio.file.FileSystem; +import java.nio.file.FileSystems; +import java.nio.file.FileVisitResult; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.SimpleFileVisitor; +import java.nio.file.attribute.BasicFileAttributes; + +import javax.swing.SwingContainer; + +/** + * @test + * @bug 8176177 + */ +public final class SwingContainerIsForContainerOnly { + + public static void main(String[] args) throws IOException { + FileSystem fs = FileSystems.getFileSystem(URI.create("jrt:/")); + fs.getFileStores(); + Files.walkFileTree(fs.getPath("/modules/java.desktop"), new SimpleFileVisitor<>() { + @Override + public FileVisitResult visitFile(Path file, + BasicFileAttributes attrs) { + file = file.subpath(2, file.getNameCount()); + String name = file.toString(); + if (name.endsWith(".class")) { + name = name.substring(0, name.indexOf(".")).replace('/', '.'); + + final Class type; + try { + type = Class.forName(name, false, null); + } catch (Throwable e) { + return FileVisitResult.CONTINUE; + } + if (type.isAnnotationPresent(SwingContainer.class)) { + if (!Container.class.isAssignableFrom(type)) { + System.err.println("Wrong annotation for: " + type); + throw new RuntimeException(); + } + } + } + return FileVisitResult.CONTINUE; + }; + }); + } +}