From e6bb5c75b38b8e9440046a4ec96cabc5965d0692 Mon Sep 17 00:00:00 2001 From: Richard Reingruber Date: Thu, 11 Jun 2026 07:46:30 +0000 Subject: [PATCH] 8386456: Comments at the declaration of frame::frame_alignment are incorrect on some platforms Reviewed-by: pchilanomate, amitkumar --- src/hotspot/cpu/arm/frame_arm.hpp | 1 + src/hotspot/cpu/ppc/frame_ppc.hpp | 3 +-- src/hotspot/cpu/x86/frame_x86.hpp | 3 +-- src/hotspot/cpu/zero/frame_zero.hpp | 1 + 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/hotspot/cpu/arm/frame_arm.hpp b/src/hotspot/cpu/arm/frame_arm.hpp index 6d4ac042831..026bd993981 100644 --- a/src/hotspot/cpu/arm/frame_arm.hpp +++ b/src/hotspot/cpu/arm/frame_arm.hpp @@ -61,6 +61,7 @@ // between a callee frame and its stack arguments, where it is part // of the caller/callee overlap metadata_words_at_top = 0, + // in bytes frame_alignment = 16, // size, in words, of maximum shift in frame position due to alignment align_wiggle = 1 diff --git a/src/hotspot/cpu/ppc/frame_ppc.hpp b/src/hotspot/cpu/ppc/frame_ppc.hpp index ebe5d24c072..14743c7d75a 100644 --- a/src/hotspot/cpu/ppc/frame_ppc.hpp +++ b/src/hotspot/cpu/ppc/frame_ppc.hpp @@ -402,8 +402,7 @@ // between a callee frame and its stack arguments, where it is part // of the caller/callee overlap metadata_words_at_top = sizeof(java_abi) >> LogBytesPerWord, - // size, in words, of frame metadata at the frame top that needs - // to be reserved for callee functions in the runtime + // in bytes frame_alignment = 16, frame_alignment_in_words = frame_alignment >> LogBytesPerWord, // size, in words, of maximum shift in frame position due to alignment diff --git a/src/hotspot/cpu/x86/frame_x86.hpp b/src/hotspot/cpu/x86/frame_x86.hpp index 2d382c7e5e5..546c40fffe4 100644 --- a/src/hotspot/cpu/x86/frame_x86.hpp +++ b/src/hotspot/cpu/x86/frame_x86.hpp @@ -101,8 +101,7 @@ // between a callee frame and its stack arguments, where it is part // of the caller/callee overlap metadata_words_at_top = 0, - // size, in words, of frame metadata at the frame top that needs - // to be reserved for callee functions in the runtime + // in bytes frame_alignment = 16, // size, in words, of maximum shift in frame position due to alignment align_wiggle = 1 diff --git a/src/hotspot/cpu/zero/frame_zero.hpp b/src/hotspot/cpu/zero/frame_zero.hpp index af9abe22cbe..19096615594 100644 --- a/src/hotspot/cpu/zero/frame_zero.hpp +++ b/src/hotspot/cpu/zero/frame_zero.hpp @@ -39,6 +39,7 @@ // between a callee frame and its stack arguments, where it is part // of the caller/callee overlap metadata_words_at_top = 0, + // in bytes frame_alignment = 16, // size, in words, of maximum shift in frame position due to alignment align_wiggle = 1