From e9b4696acc966d96d42880e840c8fe27434e4e1b Mon Sep 17 00:00:00 2001
From: Christian Stein <cstein@openjdk.org>
Date: Wed, 17 Dec 2025 07:18:26 +0000
Subject: [PATCH] 8373097: Save command should create missing parent
 directories

Reviewed-by: jlahoda
---
 .../jdk/internal/jshell/tool/JShellTool.java       | 14 +++++++++++++-
 test/langtools/jdk/jshell/ToolBasicTest.java       |  5 ++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java b/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
index 795321253fd..9a030f7e46b 100644
--- a/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
+++ b/src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
@@ -3362,7 +3362,19 @@ public class JShellTool implements MessageHandler {
             // error occurred, already reported
             return false;
         }
-        try (BufferedWriter writer = Files.newBufferedWriter(toPathResolvingUserHome(filename),
+        // Create missing parent directories before writing to target file
+        Path target;
+        try {
+            target = toPathResolvingUserHome(filename);
+            Path parent = target.getParent();
+            if (parent != null) {
+                Files.createDirectories(parent);
+            }
+        } catch (Exception e) {
+            errormsg("jshell.err.file.exception", "/save", filename, e);
+            return false;
+        }
+        try (BufferedWriter writer = Files.newBufferedWriter(target,
                 Charset.defaultCharset(),
                 CREATE, TRUNCATE_EXISTING, WRITE)) {
             if (at.hasOption("-history")) {
diff --git a/test/langtools/jdk/jshell/ToolBasicTest.java b/test/langtools/jdk/jshell/ToolBasicTest.java
index 5015d1f64b1..7fba0a9cd44 100644
--- a/test/langtools/jdk/jshell/ToolBasicTest.java
+++ b/test/langtools/jdk/jshell/ToolBasicTest.java
@@ -585,6 +585,7 @@ public class ToolBasicTest extends ReplToolTesting {
         Compiler compiler = new Compiler();
         Path path = compiler.getPath("testSave.repl");
         {
+            Path pathWithDirectories = compiler.getPath("what/ever/testSave.repl");
             List<String> list = Arrays.asList(
                     "int a;",
                     "class A { public String toString() { return \"A\"; } }"
@@ -593,9 +594,11 @@ public class ToolBasicTest extends ReplToolTesting {
                     (a) -> assertVariable(a, "int", "a"),
                     (a) -> assertCommand(a, "()", null, null, null, "", ""),
                     (a) -> assertClass(a, "class A { public String toString() { return \"A\"; } }", "class", "A"),
-                    (a) -> assertCommand(a, "/save " + path.toString(), "")
+                    (a) -> assertCommand(a, "/save " + path.toString(), ""),
+                    (a) -> assertCommand(a, "/save " + pathWithDirectories.toString(), "")
             );
             assertEquals(list, Files.readAllLines(path));
+            assertEquals(list, Files.readAllLines(pathWithDirectories));
         }
         {
             List<String> output = new ArrayList<>();