From ec901f28c3fde1aa7cef0ea41fe8bc3896ad962e Mon Sep 17 00:00:00 2001 From: Xue-Lei Andrew Fan Date: Tue, 14 Feb 2023 15:36:09 +0000 Subject: [PATCH] 8301279: update for deprecated sprintf for management components Reviewed-by: kevinw, dholmes --- .../share/native/libmanagement/VMManagementImpl.c | 2 +- src/java.management/share/native/libmanagement/management.c | 2 +- .../share/native/libmanagement_ext/management_ext.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/java.management/share/native/libmanagement/VMManagementImpl.c b/src/java.management/share/native/libmanagement/VMManagementImpl.c index 38a5b6af0cc..46f3b03b18e 100644 --- a/src/java.management/share/native/libmanagement/VMManagementImpl.c +++ b/src/java.management/share/native/libmanagement/VMManagementImpl.c @@ -44,7 +44,7 @@ Java_sun_management_VMManagementImpl_getVersion0 // for internal use unsigned int micro = (unsigned int) jmm_version & 0xFF; - sprintf(buf, "%d.%d", major, minor); + snprintf(buf, sizeof(buf), "%d.%d", major, minor); version_string = (*env)->NewStringUTF(env, buf); return version_string; } diff --git a/src/java.management/share/native/libmanagement/management.c b/src/java.management/share/native/libmanagement/management.c index 281e3d0ffac..4553a02c086 100644 --- a/src/java.management/share/native/libmanagement/management.c +++ b/src/java.management/share/native/libmanagement/management.c @@ -57,6 +57,6 @@ JNIEXPORT jint JNICALL void throw_internal_error(JNIEnv* env, const char* msg) { char errmsg[128]; - sprintf(errmsg, "errno: %d error: %s\n", errno, msg); + snprintf(errmsg, sizeof(errmsg), "errno: %d error: %s\n", errno, msg); JNU_ThrowInternalError(env, errmsg); } diff --git a/src/jdk.management/share/native/libmanagement_ext/management_ext.c b/src/jdk.management/share/native/libmanagement_ext/management_ext.c index 02285521042..726f1e7b5b9 100644 --- a/src/jdk.management/share/native/libmanagement_ext/management_ext.c +++ b/src/jdk.management/share/native/libmanagement_ext/management_ext.c @@ -57,6 +57,6 @@ JNIEXPORT jint JNICALL void throw_internal_error(JNIEnv* env, const char* msg) { char errmsg[128]; - sprintf(errmsg, "errno: %d error: %s\n", errno, msg); + snprintf(errmsg, sizeof(errmsg), "errno: %d error: %s\n", errno, msg); JNU_ThrowInternalError(env, errmsg); }