infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-02-04 23:48:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

8356989: Unexpected null in C2 compiled code

Browse Source 
Reviewed-by: chagedorn, kvn, thartmann
This commit is contained in:
Roland Westrelin 2025-05-26 08:33:37 +00:00
parent 9946c85e2f
commit ed4cd2acd2
2 changed files with 64 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/hotspot/share/opto/escape.cpp
View File

@ -2260,14 +2260,10 @@ void ConnectionGraph::process_call_arguments(CallNode *call) {
}
PointsToNode* src_ptn = ptnode_adr(src->_idx);
assert(src_ptn != nullptr, "should be registered");
if (arg_ptn != src_ptn) {
// Special arraycopy edge:
// A destination object's field can't have the source object
// as base since objects escape states are not related.
// Only escape state of destination object's fields affects
// escape state of fields in source object.
add_arraycopy(call, es, src_ptn, arg_ptn);
}
// Special arraycopy edge:
// Only escape state of destination object's fields affects
// escape state of fields in source object.
add_arraycopy(call, es, src_ptn, arg_ptn);
}
}
}

60
test/hotspot/jtreg/compiler/escapeAnalysis/TestArrayCopySameSrcDstInitializesNonEscapingArray.java Normal file
View File

@ -0,0 +1,60 @@
/*
* Copyright (c) 2025, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 8356989
* @summary Unexpected null in C2 compiled code
* @run main/othervm -XX:-BackgroundCompilation TestArrayCopySameSrcDstInitializesNonEscapingArray
* @run main TestArrayCopySameSrcDstInitializesNonEscapingArray
*/
public class TestArrayCopySameSrcDstInitializesNonEscapingArray {
private static volatile int volatileField;
public static void main(String[] args) {
Object obj = new Object();
for (int i = 0; i < 20_000; i++) {
test1(obj);
}
}
private static void test1(Object obj) {
A a = new A();
Object[] array = new Object[2];
array[0] = obj;
a.field = array;
System.arraycopy(array, 0, array, 1, 1);
if (a.field[1] == null) {
throw new RuntimeException("Can't be null");
}
}
private static class A {
Object[] field;
public A() {
field = null;
}
}
}