infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-02-15 12:55:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

8249230: Shenandoah: assertion failure with -XX:-ResizeTLAB

Browse Source 
Reviewed-by: rkennke
This commit is contained in:
Aleksey Shipilev 2020-07-13 11:55:26 +02:00
parent 870e67d520
commit f613d43f26
3 changed files with 204 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
View File

@ -2538,7 +2538,7 @@ void ShenandoahHeap::op_init_updaterefs() {
// for future GCLABs here.
if (UseTLAB) {
ShenandoahGCPhase phase(ShenandoahPhaseTimings::init_update_refs_manage_gclabs);
gclabs_retire(true);
gclabs_retire(ResizeTLAB);
}
if (ShenandoahVerify) {

4
src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
View File

@ -146,8 +146,8 @@ void ShenandoahMarkCompact::do_it(GCCause::Cause gc_cause) {
}
if (UseTLAB) {
heap->gclabs_retire(true);
heap->tlabs_retire(true);
heap->gclabs_retire(ResizeTLAB);
heap->tlabs_retire(ResizeTLAB);
}
OrderAccess::fence();

201
test/hotspot/jtreg/gc/shenandoah/TestResizeTLAB.java Normal file
View File

@ -0,0 +1,201 @@
/*
* Copyright (c) 2020, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*
*/
/*
* @test TestResizeTLAB
* @key randomness
* @summary Test that Shenandoah is able to work with(out) resizeable TLABs
* @requires vm.gc.Shenandoah
* @library /test/lib
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=passive
* -XX:+ShenandoahDegeneratedGC -XX:+ShenandoahVerify
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=passive
* -XX:+ShenandoahDegeneratedGC -XX:+ShenandoahVerify
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=passive
* -XX:-ShenandoahDegeneratedGC -XX:+ShenandoahVerify
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=passive
* -XX:-ShenandoahDegeneratedGC -XX:+ShenandoahVerify
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*/
/*
* @test TestResizeTLAB
* @key randomness
* @summary Test that Shenandoah is able to work with(out) resizeable TLABs
* @requires vm.gc.Shenandoah
* @library /test/lib
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=aggressive
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=aggressive
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*/
/*
* @test TestResizeTLAB
* @key randomness
* @summary Test that Shenandoah is able to work with(out) resizeable TLABs
* @requires vm.gc.Shenandoah
* @library /test/lib
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=adaptive
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=adaptive
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*/
/*
* @test TestResizeTLAB
* @key randomness
* @summary Test that Shenandoah is able to work with(out) resizeable TLABs
* @requires vm.gc.Shenandoah
* @library /test/lib
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=static
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=static
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*/
/*
* @test TestResizeTLAB
* @key randomness
* @summary Test that Shenandoah is able to work with(out) resizeable TLABs
* @requires vm.gc.Shenandoah
* @library /test/lib
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=compact
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=compact
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*/
/*
* @test TestResizeTLAB
* @key randomness
* @summary Test that Shenandoah is able to work with(out) resizeable TLABs
* @requires vm.gc.Shenandoah
* @library /test/lib
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu -XX:ShenandoahGCHeuristics=aggressive
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu -XX:ShenandoahGCHeuristics=aggressive
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*/
/*
* @test TestResizeTLAB
* @key randomness
* @summary Test that Shenandoah is able to work with(out) resizeable TLABs
* @requires vm.gc.Shenandoah
* @library /test/lib
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu
* -XX:+ShenandoahVerify
* -XX:+ResizeTLAB
* TestResizeTLAB
*
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu
* -XX:+ShenandoahVerify
* -XX:-ResizeTLAB
* TestResizeTLAB
*/
import java.util.Random;
import jdk.test.lib.Utils;
public class TestResizeTLAB {
static final long TARGET_MB = Long.getLong("target", 10_000); // 10 Gb allocation
static volatile Object sink;
public static void main(String[] args) throws Exception {
final int min = 0;
final int max = 384 * 1024;
long count = TARGET_MB * 1024 * 1024 / (16 + 4 * (min + (max - min) / 2));
Random r = Utils.getRandomInstance();
for (long c = 0; c < count; c++) {
sink = new int[min + r.nextInt(max - min)];
}
}
}