From fc3e8266929826f8e58bc76fe97423d76bc7be87 Mon Sep 17 00:00:00 2001 From: Mikhailo Seledtsov Date: Tue, 12 Sep 2023 14:40:06 +0000 Subject: [PATCH] 8314832: Few runtime/os tests ignore vm flags Reviewed-by: dholmes, lmesnik --- .../jtreg/runtime/os/THPsInThreadStackPreventionTest.java | 2 ++ test/hotspot/jtreg/runtime/os/TestHugePageDetection.java | 1 + test/hotspot/jtreg/runtime/os/TestTrimNative.java | 8 ++++++++ 3 files changed, 11 insertions(+) diff --git a/test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java b/test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java index f5ec01e43a6..261ec205d39 100644 --- a/test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java +++ b/test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java @@ -27,6 +27,7 @@ * @bug 8303215 8312182 * @summary On THP=always systems, we prevent THPs from forming within thread stacks * @library /test/lib + * @requires vm.flagless * @requires os.family == "linux" * @requires vm.debug * @requires os.arch=="amd64" | os.arch=="x86_64" | os.arch=="aarch64" @@ -40,6 +41,7 @@ * @bug 8303215 8312182 * @summary On THP=always systems, we prevent THPs from forming within thread stacks (negative test) * @library /test/lib + * @requires vm.flagless * @requires os.family == "linux" * @requires vm.debug * @requires os.arch=="amd64" | os.arch=="x86_64" | os.arch=="aarch64" diff --git a/test/hotspot/jtreg/runtime/os/TestHugePageDetection.java b/test/hotspot/jtreg/runtime/os/TestHugePageDetection.java index 2dac98000f5..80d7df080d0 100644 --- a/test/hotspot/jtreg/runtime/os/TestHugePageDetection.java +++ b/test/hotspot/jtreg/runtime/os/TestHugePageDetection.java @@ -26,6 +26,7 @@ * @test * @summary Test that the JVM detects the OS hugepage/THP settings correctly. * @library /test/lib + * @requires vm.flagless * @requires os.family == "linux" * @modules java.base/jdk.internal.misc * java.management diff --git a/test/hotspot/jtreg/runtime/os/TestTrimNative.java b/test/hotspot/jtreg/runtime/os/TestTrimNative.java index f1aed48b88e..cdc49bd4216 100644 --- a/test/hotspot/jtreg/runtime/os/TestTrimNative.java +++ b/test/hotspot/jtreg/runtime/os/TestTrimNative.java @@ -26,6 +26,7 @@ /* * @test id=trimNative + * @requires vm.flagless * @requires (os.family=="linux") & !vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib @@ -36,6 +37,7 @@ /* * @test id=trimNativeStrict + * @requires vm.flagless * @requires (os.family=="linux") & !vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib @@ -47,6 +49,7 @@ /* * @test id=trimNativeHighInterval * @summary High interval trimming should not even kick in for short program runtimes + * @requires vm.flagless * @requires (os.family=="linux") & !vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib @@ -58,6 +61,7 @@ /* * @test id=trimNativeLowInterval * @summary Very low (sub-second) interval, nothing should explode + * @requires vm.flagless * @requires (os.family=="linux") & !vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib @@ -69,6 +73,7 @@ /* * @test id=trimNativeLowIntervalStrict * @summary Very low (sub-second) interval, nothing should explode (stricter test, manual mode) + * @requires vm.flagless * @requires (os.family=="linux") & !vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib @@ -80,6 +85,7 @@ /* * @test id=testOffByDefault * @summary Test that trimming is disabled by default + * @requires vm.flagless * @requires (os.family=="linux") & !vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib @@ -91,6 +97,7 @@ /* * @test id=testOffExplicit * @summary Test that trimming can be disabled explicitly + * @requires vm.flagless * @requires (os.family=="linux") & !vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib @@ -102,6 +109,7 @@ /* * @test id=testOffOnNonCompliantPlatforms * @summary Test that trimming is correctly reported as unavailable if unavailable + * @requires vm.flagless * @requires (os.family!="linux") | vm.musl * @modules java.base/jdk.internal.misc * @library /test/lib