From b034710b2ae5fbfbe619abba86fef3b5a2d685e0 Mon Sep 17 00:00:00 2001 From: Nizar Benalla Date: Sun, 25 May 2025 12:56:55 +0000 Subject: [PATCH 1/2] 8356629: Incorrect use of {@linkplain} in java.sql Reviewed-by: lancea --- src/java.sql/share/classes/java/sql/DatabaseMetaData.java | 4 ++-- src/java.sql/share/classes/java/sql/DriverManager.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/java.sql/share/classes/java/sql/DatabaseMetaData.java b/src/java.sql/share/classes/java/sql/DatabaseMetaData.java index f4cb8787b5f..1fe1b387f42 100644 --- a/src/java.sql/share/classes/java/sql/DatabaseMetaData.java +++ b/src/java.sql/share/classes/java/sql/DatabaseMetaData.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2024, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2025, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -3589,7 +3589,7 @@ public interface DatabaseMetaData extends Wrapper { * DECIMAL_DIGITS is not applicable. *
  • NUM_PREC_RADIX int {@code =>} Radix (typically either 10 or 2) *
  • COLUMN_USAGE String {@code =>} The allowed usage for the column. The - * value returned will correspond to the enum name returned by {@link PseudoColumnUsage#name PseudoColumnUsage.name()} + * value returned will correspond to the enum name returned by {@link PseudoColumnUsage#name() PseudoColumnUsage.name()} *
  • REMARKS String {@code =>} comment describing column (may be {@code null}) *
  • CHAR_OCTET_LENGTH int {@code =>} for char types the * maximum number of bytes in the column diff --git a/src/java.sql/share/classes/java/sql/DriverManager.java b/src/java.sql/share/classes/java/sql/DriverManager.java index 7620a11e6fd..2f51dee5e70 100644 --- a/src/java.sql/share/classes/java/sql/DriverManager.java +++ b/src/java.sql/share/classes/java/sql/DriverManager.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2024, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2025, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -59,7 +59,7 @@ import jdk.internal.reflect.Reflection; * * *
  • Service providers of the {@code java.sql.Driver} class, that are loaded - * via the {@linkplain ServiceLoader#load service-provider loading} mechanism. + * via the {@linkplain ServiceLoader#load(Class) service-provider loading} mechanism. * * * @implNote From 4a4209ffef8f8d65054cbf46ebf8e169d100c0d8 Mon Sep 17 00:00:00 2001 From: Shaojin Wen Date: Sun, 25 May 2025 17:39:53 +0000 Subject: [PATCH 2/2] 8357685: Change the type of Integer::digits from char[] to byte[] Reviewed-by: rgiulietti, liach --- src/java.base/share/classes/java/lang/Integer.java | 9 +++++---- src/java.base/share/classes/java/lang/Long.java | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/java.base/share/classes/java/lang/Integer.java b/src/java.base/share/classes/java/lang/Integer.java index a95149a3edd..41487a469b6 100644 --- a/src/java.base/share/classes/java/lang/Integer.java +++ b/src/java.base/share/classes/java/lang/Integer.java @@ -100,7 +100,8 @@ public final class Integer extends Number /** * All possible chars for representing a number as a String */ - static final char[] digits = { + @Stable + static final byte[] digits = { '0' , '1' , '2' , '3' , '4' , '5' , '6' , '7' , '8' , '9' , 'a' , 'b' , 'c' , 'd' , 'e' , 'f' , 'g' , 'h' , @@ -172,10 +173,10 @@ public final class Integer extends Number } while (i <= -radix) { - buf[charPos--] = (byte)digits[-(i % radix)]; + buf[charPos--] = digits[-(i % radix)]; i = i / radix; } - buf[charPos] = (byte)digits[-i]; + buf[charPos] = digits[-i]; if (negative) { buf[--charPos] = '-'; @@ -392,7 +393,7 @@ public final class Integer extends Number int radix = 1 << shift; int mask = radix - 1; do { - buf[--charPos] = (byte)Integer.digits[val & mask]; + buf[--charPos] = Integer.digits[val & mask]; val >>>= shift; } while (charPos > 0); } diff --git a/src/java.base/share/classes/java/lang/Long.java b/src/java.base/share/classes/java/lang/Long.java index 20e07f41b9e..2fb2d18a78c 100644 --- a/src/java.base/share/classes/java/lang/Long.java +++ b/src/java.base/share/classes/java/lang/Long.java @@ -157,10 +157,10 @@ public final class Long extends Number } while (i <= -radix) { - buf[charPos--] = (byte)Integer.digits[(int)(-(i % radix))]; + buf[charPos--] = Integer.digits[(int)(-(i % radix))]; i = i / radix; } - buf[charPos] = (byte)Integer.digits[(int)(-i)]; + buf[charPos] = Integer.digits[(int)(-i)]; if (negative) { buf[--charPos] = '-'; @@ -422,7 +422,7 @@ public final class Long extends Number int radix = 1 << shift; int mask = radix - 1; do { - buf[--charPos] = (byte)Integer.digits[((int) val) & mask]; + buf[--charPos] = Integer.digits[((int) val) & mask]; val >>>= shift; } while (charPos > offset); }