infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-04-23 05:10:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

8295461: IGV: Wrong src/dest nodes highlighted for edge

Browse Source 
Reviewed-by: thartmann, rcastanedalo
This commit is contained in:
Tobias Holenstein 2022-10-24 14:14:12 +00:00
parent d50b6eb342
commit 3898385788
1 changed files with 38 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/widgets/LineWidget.java
View File

@ -239,27 +239,6 @@ public class LineWidget extends Widget implements PopupMenuProvider {
g.setStroke(oldStroke);
}
private void setHighlighted(boolean b) {
this.highlighted = b;
Set<Object> highlightedObjects = new HashSet<>(scene.getHighlightedObjects());
Set<Object> highlightedObjectsChange = new HashSet<>();
for (Connection c : connections) {
if (c.hasSlots()) {
highlightedObjectsChange.add(c.getTo());
highlightedObjectsChange.add(c.getTo().getVertex());
highlightedObjectsChange.add(c.getFrom());
highlightedObjectsChange.add(c.getFrom().getVertex());
}
}
if(b) {
highlightedObjects.addAll(highlightedObjectsChange);
} else {
highlightedObjects.removeAll(highlightedObjectsChange);
}
scene.setHighlightedObjects(highlightedObjects);
this.revalidate(true);
}
private void setPopupVisible(boolean b) {
this.popupVisible = b;
this.revalidate(true);
@ -273,28 +252,53 @@ public class LineWidget extends Widget implements PopupMenuProvider {
@Override
protected void notifyStateChanged(ObjectState previousState, ObjectState state) {
if (previousState.isHovered() != state.isHovered()) {
setRecursiveHighlighted(state.isHovered());
boolean enableHighlighting = state.isHovered();
highlightPredecessors(enableHighlighting);
setHighlighted(enableHighlighting);
recursiveHighlightSuccessors(enableHighlighting);
highlightVertices(enableHighlighting);
}
}
private void setRecursiveHighlighted(boolean b) {
LineWidget cur = predecessor;
while (cur != null) {
cur.setHighlighted(b);
cur = cur.predecessor;
private void highlightPredecessors(boolean enable) {
LineWidget predecessorLineWidget = predecessor;
while (predecessorLineWidget != null) {
predecessorLineWidget.setHighlighted(enable);
predecessorLineWidget = predecessorLineWidget.predecessor;
}
highlightSuccessors(b);
this.setHighlighted(b);
}
private void highlightSuccessors(boolean b) {
for (LineWidget s : successors) {
s.setHighlighted(b);
s.highlightSuccessors(b);
private void recursiveHighlightSuccessors(boolean enable) {
for (LineWidget successorLineWidget : successors) {
successorLineWidget.setHighlighted(enable);
successorLineWidget.recursiveHighlightSuccessors(enable);
}
}
private void highlightVertices(boolean enable) {
Set<Object> highlightedObjects = new HashSet<>(scene.getHighlightedObjects());
Set<Object> highlightedObjectsChange = new HashSet<>();
for (Connection c : connections) {
if (c.hasSlots()) {
highlightedObjectsChange.add(c.getTo());
highlightedObjectsChange.add(c.getTo().getVertex());
highlightedObjectsChange.add(c.getFrom());
highlightedObjectsChange.add(c.getFrom().getVertex());
}
}
if (enable) {
highlightedObjects.addAll(highlightedObjectsChange);
} else {
highlightedObjects.removeAll(highlightedObjectsChange);
}
scene.setHighlightedObjects(highlightedObjects);
}
private void setHighlighted(boolean enable) {
highlighted = enable;
revalidate(true);
}
private void setRecursivePopupVisible(boolean b) {
LineWidget cur = predecessor;
while (cur != null) {